Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child ref function called again with CSSTransitionGroupChild #61

Closed
fdev opened this issue Mar 27, 2019 · 3 comments
Closed

Child ref function called again with CSSTransitionGroupChild #61

fdev opened this issue Mar 27, 2019 · 3 comments

Comments

@fdev
Copy link

fdev commented Mar 27, 2019

Current behavior
The ref function given to the child component is called with both the child component refence and the CSSTransitionGroupChild component.

Expected behavior
The ref function should on be called with the child component.

Steps to reproduce
See the example and console output on https://codesandbox.io/s/5v2nm9zo0l?expanddevtools=1

References
Related issue in react-transition-group can be found at reactjs/react-transition-group#29 (merged fix in reactjs/react-transition-group#39)

@marnusw
Copy link
Owner

marnusw commented Mar 27, 2019

Thank you for reporting this and for the reference to the merged fix. I will take a look.

@marnusw
Copy link
Owner

marnusw commented Oct 11, 2019

I'm sorry it took months to get round to this. I've published 4.0.2-beta.0 with a fix. Would you be able to confirm that everything now works as expected? I don't have a real use case for it so it's hard to be definitive in saying that it works.

@fdev
Copy link
Author

fdev commented Oct 11, 2019

I have forked the sandbox example to use version 4.0.2-beta.0 and the issue seems to have been fixed, thanks!

@fdev fdev closed this as completed Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants