Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use server autoreloader when not running on localhost #513

Open
ThiefMaster opened this issue Mar 18, 2023 · 1 comment
Open

Can't use server autoreloader when not running on localhost #513

ThiefMaster opened this issue Mar 18, 2023 · 1 comment

Comments

@ThiefMaster
Copy link

It looks like the live reload of the marpit server always tries to connect to localhost. This doesn't work if you use a different hostname. Especially in the era of remote editing this is not uncommon. It would be nice if:

  • the current hostname used to access the server was used instead of the hardcoded localhost
  • ideally the same port was used for the websocket instead of a different port (just use a subpath like /live-reload-ws)

By doing so it would work on localhost but also any thing else. For example in my own environment I run on https://marp.mydevhost.mydomain (I have a wildcard cert and nginx forward that subdomain to the marpit server), but by doing so I lose the reloader functionality...

@yhatt yhatt transferred this issue from marp-team/marpit Mar 19, 2023
@yhatt
Copy link
Member

yhatt commented Mar 19, 2023

Marpit framework does never provide any HTTP/WebSocket server. I've transferred the issue to Marp CLI. 🚚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants