Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marp crashes with NodeJS LTS 18.18.0 #546

Closed
chrisdecker1201 opened this issue Sep 22, 2023 · 3 comments
Closed

Marp crashes with NodeJS LTS 18.18.0 #546

chrisdecker1201 opened this issue Sep 22, 2023 · 3 comments
Labels
upstream Caused in upstream, not in this repo

Comments

@chrisdecker1201
Copy link

chrisdecker1201 commented Sep 22, 2023

Version of Marp Tool

Marp CLI v3.2.1

Operating System

Windows

Environment

  • OS version: Windows 10
  • Node.js version: 18.18.0 (LTS)
  • Marp CLI: v3.2.1

How to reproduce

  1. Install NodeJS 18.18.0 on Windows via choco
choco install nodejs-lts --version=18.18.0
  1. Install Marp CLI
npm install -g @marp-team/marp-cli
  1. Execute marp in server mode
marp -s -I .

Expected behavior

Same behaviour like in version 18.17.0.

I downgraded now and it's working :)

Actual behavior

The marp-cli command just return this error.

node:internal/fs/promises:590
    await binding.openFileHandle(pathModule.toNamespacedPath(path),
                  ^

Error: ENOENT: no such file or directory, open
    at open (node:internal/fs/promises:590:19)
    at Object.readFile (node:internal/fs/promises:1025:20)
    at Bc.load (C:\Users\tb10dcc\AppData\Roaming\npm\node_modules\@marp-team\marp-cli\lib\marp-cli-376cca40.js:27:75570)
    at o (C:\Users\tb10dcc\AppData\Roaming\npm\node_modules\@marp-team\marp-cli\lib\marp-cli-376cca40.js:43:90184)
    at Lp.convertFile (C:\Users\tb10dcc\AppData\Roaming\npm\node_modules\@marp-team\marp-cli\lib\marp-cli-376cca40.js:43:91002)
    at Lp.convertFiles (C:\Users\tb10dcc\AppData\Roaming\npm\node_modules\@marp-team\marp-cli\lib\marp-cli-376cca40.js:43:91214)
    at async Vp (C:\Users\tb10dcc\AppData\Roaming\npm\node_modules\@marp-team\marp-cli\lib\marp-cli-376cca40.js:43:126747) {
  errno: -4058,
  code: 'ENOENT',
  syscall: 'open'
}

Node.js v18.18.0

Additional information

I use this here for just saying thank you for this great tool ❤.

@chrisdecker1201 chrisdecker1201 added the bug Something isn't working label Sep 22, 2023
@yhatt
Copy link
Member

yhatt commented Sep 23, 2023

I've tested with Node.js 18.18.0 installed via the msi installer, but I could not reproduce the error on my Windows. If the error was brought by the specific directory structure, please share the structure for reproduction.

The stack trace shows it has brought the error by the Node.js internal module so Node.js installed via Chocolately might be causing something wrong (I could not test because I'm not a Chocolately user). It's hard to imagine there are some internal differences in the Node.js binary between installed via msi and via Chocolately, but I recommend reporting it to the Node.js issue tracker if it could reproduce also in the Node.js via msi installer.

@yhatt yhatt added upstream Caused in upstream, not in this repo need more info labels Sep 23, 2023
@yhatt yhatt removed the bug Something isn't working label Sep 23, 2023
@chrisdecker1201
Copy link
Author

chrisdecker1201 commented Sep 25, 2023

I just uninstalled nodejs-lts with choco

choco uninstall nodejs-lts

And installed NodeJS 18.18.0 from the MSI (https://nodejs.org/en/download), but I'm still getting this error...
I will open a bug on Node.js

@yhatt
Copy link
Member

yhatt commented Sep 25, 2023

Caused by upstream: nodejs/node#48673

@yhatt yhatt closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Caused in upstream, not in this repo
Projects
None yet
Development

No branches or pull requests

2 participants