Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: File conversions using Firefox through WebDriver BiDi #565

Open
yhatt opened this issue Dec 19, 2023 · 0 comments
Open

Experiment: File conversions using Firefox through WebDriver BiDi #565

yhatt opened this issue Dec 19, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@yhatt
Copy link
Member

yhatt commented Dec 19, 2023

Background

Mozilla and Google have announced that Puppeteer now supports WebDriver BiDi protocol. The headless Firefox could not generate PDF for a long time. But now, Firefox becomes able to generate PDF through WebDriver BiDi (Since Firefox 112: https://bugzil.la/1806810)

The support for other functions Marp CLI is depending is still in progress, but that is well worth to try to support PDF/PPTX/image conversion using Firefox.

Most Linux distributions have installed Firefox as a default browser. If implemented the auto-detection of Firefox binary path, Linux users may no longer have to worry about installed browsers. It's important because Marp ecosystem should be easy to touch for everyone.

Related pages

Related issues

Concerns

  • Currently Firefox does not support Page.pdf({ preferCSSPageSize: true }). Marp CLI conversion logic has to set the proper width and height instead of relying on Marpit's printable option.
  • Firefox emits only PNG file even if used page.screenshot with type option as another file type.
@yhatt yhatt added the enhancement New feature or request label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant