Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New line between breaking changes and issues #12

Closed
btd1337 opened this issue Jun 28, 2021 · 3 comments · Fixed by #14
Closed

New line between breaking changes and issues #12

btd1337 opened this issue Jun 28, 2021 · 3 comments · Fixed by #14

Comments

@btd1337
Copy link

btd1337 commented Jun 28, 2021

Hi @martinmcwhorter could do you see this behavior?

When u insert one breaking change and report one referenced issue commit is generate thus:

`BREAKING CHANGE: Example``fix #123`

Would be great if could be like that:

`BREAKING CHANGE: Example`
`fix #123`
@martinmcwhorter
Copy link
Owner

@shoichiaizawa
Copy link

shoichiaizawa commented Jul 1, 2021

I am also trying to test out commitiquette over the cz-conventional-changelog adapter that doesn't support a selectable scope list. The commitiquette does the job so cool :D

Here is the output of commitiquette with every prompt answered:

feat(core): add some feature to core

A longer description goes on and on and on and on.
BREAKING CHANGE: The description for the breaking change goes here.Close: #123

Other than the missing linebreak of the footer section, based on the Conventional Commits format, there should be a linebreak between the "a longer description" section and the "footer" section.

For instance, here is the output of cz-conventional-changelog with every prompt answered:

feat(core): add some feature to core

A longer description goes on and on and on and on.

BREAKING CHANGE: The description for the breaking change goes here.

Close: #123

@martinmcwhorter
Copy link
Owner

@shoichiaizawa this is great stuff.

This will get fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants