New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflict on rebase clears execute flag on script #3579
Labels
🐛bug
Something isn't working
Comments
|
Nice. I knew there had to be a clever revset to do that. |
I think this is down to conflict materialisation not yet looking through the merge at file bits. I'll have a go at fixing it. |
gulbanana
added a commit
to gulbanana/jj
that referenced
this issue
Apr 26, 2024
…rialise the conflicted file as executable fixes martinvonz#3579
gulbanana
added a commit
to gulbanana/jj
that referenced
this issue
Apr 26, 2024
…rialise the conflicted file as executable fixes martinvonz#3579
gulbanana
added a commit
to gulbanana/jj
that referenced
this issue
Apr 26, 2024
…rialise the conflicted file as executable fixes martinvonz#3579
gulbanana
added a commit
to gulbanana/jj
that referenced
this issue
Apr 26, 2024
…rialise the conflicted file as executable fixes martinvonz#3579
gulbanana
added a commit
to gulbanana/jj
that referenced
this issue
Apr 26, 2024
…rialise the conflicted file as executable Fixes martinvonz#3579 and adds a testcase for an executable conflict treevalue.
gulbanana
added a commit
to gulbanana/jj
that referenced
this issue
Apr 26, 2024
…rialise the conflicted file as executable Fixes martinvonz#3579 and adds a testcase for an executable conflict treevalue.
gulbanana
added a commit
to gulbanana/jj
that referenced
this issue
May 4, 2024
…rialise the conflicted file as executable Fixes martinvonz#3579 and adds a testcase for an executable conflict treevalue.
gulbanana
added a commit
to gulbanana/jj
that referenced
this issue
May 4, 2024
…rialise the conflicted file as executable Fixes martinvonz#3579 and adds a testcase for an executable conflict treevalue.
gulbanana
added a commit
to gulbanana/jj
that referenced
this issue
May 4, 2024
…rialise the conflicted file as executable Fixes martinvonz#3579 and adds a testcase for an executable conflict treevalue.
gulbanana
added a commit
to gulbanana/jj
that referenced
this issue
May 4, 2024
…rialise the conflicted file as executable Fixes martinvonz#3579 and adds a testcase for an executable conflict treevalue.
gulbanana
added a commit
to gulbanana/jj
that referenced
this issue
May 21, 2024
…rialise the conflicted file as executable Fixes martinvonz#3579 and adds a testcase for an executable conflict treevalue.
gulbanana
added a commit
that referenced
this issue
May 21, 2024
…rialise the conflicted file as executable Fixes #3579 and adds a testcase for an executable conflict treevalue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
If a script in a repo has perms 755, but a rebase causes a conflict in the script, the conflicted file's perms get set to 644 and remain so after the conflict is resolved.
Steps to Reproduce the Problem
jj rebase -r <REV1> -d <REV2>
(I don't know how to script that, unfortunately...)jj new -r REV1
to resolve the conflict.Expected Behavior
The permissions on
script.sh
remain 755.Actual Behavior
The permissions on
script.sh
are changed to 644 in the conflicted state and remain so after resolution.Specifications
jj 0.16.0
The text was updated successfully, but these errors were encountered: