Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release binaries show the git hash in their version output. #3629

Open
edre opened this issue May 6, 2024 · 0 comments · May be fixed by #3638
Open

Release binaries show the git hash in their version output. #3629

edre opened this issue May 6, 2024 · 0 comments · May be fixed by #3638

Comments

@edre
Copy link
Contributor

edre commented May 6, 2024

Description

The release snapshots presumably don't mean to imply that there are further changes from the release tag. The release process however runs in a git repo, and thus it includes the version. Either the release process could delete the .git directory, or otherwise checkout just the files.

Steps to Reproduce the Problem

  1. Download release binary from github
  2. jj version

Expected Behavior

jj 0.17.0

Actual Behavior

jj 0.17.0-19563fee7483ecd6b5f56200520ac81c84ea16c5

Specifications

  • Platform: Linux musl
  • Version: 0.17.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant