Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency of DEFINE_LOAD_LIBRARY on DEFINE_SCRIPT_DIR #148

Open
felipecrs opened this issue Feb 3, 2021 · 0 comments
Open

Comments

@felipecrs
Copy link
Contributor

Currently, if you set DEFINE_LOAD_LIBRARY without DEFINE_SCRIPT_DIR, it will fail with:

argbash -i pipeline/scripts/get_version_from_registry.sh
stdin:38: error: You have to define a script directory by some means before using 'DEFINE_LOAD_LIBRARY'
stdin:38: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
Error during autom4te run, aborting!

Argbash could handle this case, by making the DEFINE_LOAD_LIBRARY not use the $script_dir variable, in case it was not set. If set, then it would be good to reuse.

This is useful because, in 80% of the cases (I believe), the use of the $script_dir variable is just for importing a library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant