Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support built-in test explorer #270

Closed
Trass3r opened this issue Aug 5, 2021 · 13 comments
Closed

support built-in test explorer #270

Trass3r opened this issue Aug 5, 2021 · 13 comments
Labels
v4.x Expected to be addressed in the next major release

Comments

@Trass3r
Copy link

Trass3r commented Aug 5, 2021

This issue is to track support for the new built-in Test Explorer: https://code.visualstudio.com/updates/v1_59#_testing-apis
I saw there's a branch already: https://github.com/matepek/vscode-catch2-test-adapter/compare/vscode-insider-proposed-test-api

@matepek matepek added the v4.x Expected to be addressed in the next major release label Aug 9, 2021
@matepek
Copy link
Owner

matepek commented Aug 9, 2021

The API has changed a lot since. I have to start from scratch.

@SizaSL
Copy link
Contributor

SizaSL commented Aug 30, 2021

Just in case if you want to try out the vscode native test UI. Set the following settings in settings.json.

"testExplorer.useNativeTesting": true

This will use the native test UI and you will be able to use most of it's features.

@Trass3r
Copy link
Author

Trass3r commented Aug 30, 2021

@SizaSL
Copy link
Contributor

SizaSL commented Aug 31, 2021

I see, so the UI is decoupled from the API: https://marketplace.visualstudio.com/items?itemName=hbenl.vscode-test-explorer#migrating-to-native-testing

I believe Microsoft provided test adapter converter extensions. Test Explorer UI is depend on that to enable native UI.

@matepek
Copy link
Owner

matepek commented Aug 31, 2021

Added new activation events to support "testExplorer.useNativeTesting": true.

@bilderbuchi
Copy link

I think I'm seeing this behaviour (Test explorer flask icon disappears when switching on native UI) using v3.6.30 with Test Explorer UI 2.21.1, can anyone reproduce

@SizaSL
Copy link
Contributor

SizaSL commented Sep 2, 2021

I think I'm seeing this behaviour (Test explorer flask icon disappears when switching on native UI) using v3.6.30 with Test Explorer UI 2.21.1, can anyone reproduce

There is a PR waiting to be approved will fix this.

@bilderbuchi
Copy link

Oops, I missed this, sorry.

@Trass3r
Copy link
Author

Trass3r commented Oct 5, 2021

Added new activation events to support "testExplorer.useNativeTesting": true.

Test duration doesn't seem to get updated after the first run. Does that also happen for you guys? Is it a VSCode problem?

@matepek
Copy link
Owner

matepek commented Oct 6, 2021

If it is updated while "testExplorer.useNativeTesting": false then I'm afraid this issue is not related to this extension but rather to test-explorer or vscode.

Out of scope, sorry.

BTW I'm working on the native vscode test api which will open the window for new features but also misses some. I'm not sure how I should proceed.
Thinking...

@Trass3r
Copy link
Author

Trass3r commented Oct 6, 2021

No it's with the native Test UI.
It also still has some missing features from the UI point of view, but we'll get there.
https://github.com/microsoft/vscode/labels/testing

Apparently the next features are:

Provide support for tags vscode#129456 @connor4312
Support non-error output for test runs vscode#129201 @connor4312
💪 Explore APIs for test coverage vscode#123713 @connor4312

@matepek
Copy link
Owner

matepek commented Oct 6, 2021

I haven't expressed my self well.

Currently this extension is built upon test-explorer by hblen. It doesn't uses the native vscode testing api.
There is a wrapper/bridge (inside test-explorer) which translate the calls to the native vscode testing api when "testExplorer.useNativeTesting": true is set. That is the test-explorer's inner business.

Therefore anything working with "testExplorer.useNativeTesting": false is most likely not related to this extension.

Also there is an ongoing work to support the native api.

@matepek
Copy link
Owner

matepek commented Nov 22, 2021

Dear User(s),

Version 4+ has been release. Hoping it makes this issue resolved.
If you disagree then please comment !open.

@matepek matepek closed this as completed Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4.x Expected to be addressed in the next major release
Projects
None yet
Development

No branches or pull requests

4 participants