Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context.theme.key, getDeclaredMethod will always throw if we target SDK 32 #93

Open
KoTius opened this issue May 20, 2022 · 2 comments
Open

Comments

@KoTius
Copy link

KoTius commented May 20, 2022

If we target SDK32 the Resources.Theme::class.java.getDeclaredMethod("getKey") will always throw so we can't use this method for re-compositions optimizations for createMdcTheme()

@ricknout
Copy link
Contributor

Thanks for raising this. Unfortunately SDK 32 has changed Resources.Theme.getKey to a hidden method, so the current reflection implementation can't work. I'll think about this some more but perhaps the fallback of just using the theme directly as a key is fine.

@StylianosGakis
Copy link

Is this still a problem? Sounds like something which needs adressing, especially since we're at API 33 as a stable release already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants