Skip to content

Commit 703249d

Browse files
Material Design Teamleticiarossi
Material Design Team
authored andcommittedMay 13, 2022
[MaterialTimePicker] Properly align text vertically in MaterialTimePicker on S+.
PiperOrigin-RevId: 448541243
1 parent 4b81bb1 commit 703249d

File tree

3 files changed

+24
-1
lines changed

3 files changed

+24
-1
lines changed
 

‎lib/java/com/google/android/material/timepicker/res/layout/material_time_input.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
android:layout_width="96dp"
2727
android:textCursorDrawable="@drawable/material_cursor_drawable"
2828
android:layout_height="80dp"
29-
android:paddingBottom="6dp" />
29+
android:paddingBottom="@dimen/material_time_input_padding_bottom" />
3030

3131
<TextView
3232
android:id="@+id/material_label"
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<!--
3+
Copyright 2022 The Android Open Source Project
4+
5+
Licensed under the Apache License, Version 2.0 (the "License");
6+
you may not use this file except in compliance with the License.
7+
You may obtain a copy of the License at
8+
9+
http://www.apache.org/licenses/LICENSE-2.0
10+
11+
Unless required by applicable law or agreed to in writing, software
12+
distributed under the License is distributed on an "AS IS" BASIS,
13+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
See the License for the specific language governing permissions and
15+
limitations under the License.
16+
-->
17+
18+
<resources>
19+
<!-- TextInputEditText centers properly on S+, so padding is not needed -->
20+
<dimen name="material_time_input_padding_bottom">0dp</dimen>
21+
</resources>

‎lib/java/com/google/android/material/timepicker/res/values/dimens.xml

+2
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@
3636
<dimen name="material_cursor_width">2dp</dimen>
3737

3838
<dimen name="material_clock_size">256dp</dimen>
39+
<!-- TextInputEditText doesn't properly center pre-S, so add padding fix -->
40+
<dimen name="material_time_input_padding_bottom">6dp</dimen>
3941

4042
<dimen name="material_time_picker_minimum_screen_height">560dp</dimen>
4143
<dimen name="material_time_picker_minimum_screen_width">340dp</dimen>

0 commit comments

Comments
 (0)
Please sign in to comment.