Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsure, but documentation for change event seems wrong for md-tabs #5610

Closed
Dakotys opened this issue May 3, 2024 · 1 comment
Closed

Unsure, but documentation for change event seems wrong for md-tabs #5610

Dakotys opened this issue May 3, 2024 · 1 comment
Assignees

Comments

@Dakotys
Copy link
Contributor

Dakotys commented May 3, 2024

Description

In documentation are mentioned link link2 selectedItem property and other properties that no longer exist, they have been at some point replaced with activeTabIndex link.
Also maybe example of eventListener directly in documentation for Events could be helpful. (I wouldn't have to question my js knowledge and whether I am doing something wrong and instead would check potention flaws in source code first. )<3

Browser/OS Environment

No response

@Dakotys Dakotys changed the title Unsure, but documentation for change event seems wrog Unsure, but documentation for change event seems wrong for md-tabs May 3, 2024
copybara-service bot pushed a commit that referenced this issue May 23, 2024
@asyncLiz
Copy link
Collaborator

Thanks for the issue, and sorry for the delay! I'm sending out #5627 to fix the docs.

For the event doc examples, I agree that would be a good enhancement! Maybe add a comment on Better docs needed (#5407)?

@asyncLiz asyncLiz self-assigned this May 23, 2024
copybara-service bot pushed a commit that referenced this issue May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants