Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PopperJS instead of custom Dropdown-Component #268

Open
wuda-io opened this issue Jun 1, 2022 · 3 comments
Open

Use PopperJS instead of custom Dropdown-Component #268

wuda-io opened this issue Jun 1, 2022 · 3 comments

Comments

@wuda-io
Copy link
Member

wuda-io commented Jun 1, 2022

I have recently switched to PopperJS in my own Projects PopperJS or now called https://github.com/floating-ui/floating-ui
I already saw that Bootstrap is using it for a long time. In Materialize we currently have our own implementation with the Dropdown Component. But what do you think about switch/implementing to this Library since it is well supported and
already after 1 week i see nice improvements.

This solves nested Dropdowns for me, as they were not possible with the current setup.

Here you can see an example:
Screenshot 2022-06-01 111329

What do you guys think? Should we implement it?

@jshster
Copy link

jshster commented Jun 2, 2022

Certainly looks reasonable. My only concern would be co-dependencies. What if that project gets abandoned? What does that mean for Materialize?

@wuda-io
Copy link
Member Author

wuda-io commented Jun 3, 2022

Yess you are right, I also like to have no or less dependencies...

We can fork or implement it as a copy, so we dont have to rely on the project.
Also it is very small, so i see not much of a issue here. We can just copy the JS-File.
Also we have dependencies from waves.js as i remeber.

I dont know why Bootstrap is using it as a seperate CDN-Link implementation. Maybe for saving the space.

@DanielRuf
Copy link

@materializecss/members

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants