Transform regex with 'su' flag, using dotAllFlag=false

[meowtec]

rewritePattern('hello.world', 'su', {
  dotAllFlag: false,
})

/hello.world/su.test('hello\nworld') 
// should output: true

/hello(?:[\0-\t\x0B\f\x0E-\u2027\u202A-\uD7FF\uE000-\uFFFF]|[\uD800-\uDBFF][\uDC00-\uDFFF]|[\uD800-\uDBFF](?![\uDC00-\uDFFF])|(?:[^\uD800-\uDBFF]|^)[\uDC00-\uDFFF])world/s.test('hello\nworld'))
// but output: false

[JLHwung]

It is expected. The dotAllFlag option enables the dotall-flag support.

rewritePattern('.', 's', {
  'dotAllFlag': true
});
// → '[\\0-\\uFFFF]'

[meowtec]

@JLHwung I think

rewritePattern('hello.world', 'su', {
  dotAllFlag: false,
})

should get result like this:

(?:[\0-\t\x0B\f\x0E-\u2027\u202A-\uD7FF\uE000-\uFFFF]|[\uD800-\uDBFF][\uDC00-\uDFFF]|[\uD800-\uDBFF](?![\uDC00-\uDFFF])|(?:[^\uD800-\uDBFF]|^)[\uDC00-\uDFFF])|.

(add |. at the end)

// so this will be true:
/(?:[\0-\t\x0B\f\x0E-\u2027\u202A-\uD7FF\uE000-\uFFFF]|[\uD800-\uDBFF][\uDC00-\uDFFF]|[\uD800-\uDBFF](?![\uDC00-\uDFFF])|(?:[^\uD800-\uDBFF]|^)[\uDC00-\uDFFF])|./s
.test('\n') // true

[meowtec]

Otherwise we should set dotAllFlag always to true(if has 's' flag) in proposal-unicode-property-regex because the '.' would lost before transform-dotall-regex.

[JLHwung]

@meowtec Exactly, I proposed in babel/babel#10347 (comment) and we do have a workaround in hand.

This issue comes from how babel invokes regexpu-core, so I suggest discussion in babel/babel#10347 with the a babel plugin context.