Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in the language switcher and the language itself #73

Open
samluiz opened this issue Jul 1, 2022 · 5 comments
Open

Bug in the language switcher and the language itself #73

samluiz opened this issue Jul 1, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@samluiz
Copy link

samluiz commented Jul 1, 2022

When i first entered the website, i noticed that the page was all in English, but the language switch was showing Portuguese Brazil. It started working properly after i changed it. Nothing serious, but i guess i should point that.

@mathkruger
Copy link
Owner

Hey, thanks for pointing that out! I'll be working to fix that

@mathkruger mathkruger self-assigned this Sep 6, 2022
@samluiz
Copy link
Author

samluiz commented Sep 6, 2022

Wow, sorry for my poor explanation of the problem, i had little knowledge in programming and none in Angular at that time, but now i know it might be the i18n getting the default language and setting the flag correctly, but not exactly translating. I would phrase this better nowadays.

And i've just realized you're also brazilian. Great job irmão! Amazing project.

@mathkruger
Copy link
Owner

Wow I didn't notice you're also BR 😎 Valeu for the feedback irmão!

@mathkruger mathkruger added the bug Something isn't working label Oct 11, 2022
francesco-buscicchio added a commit to francesco-buscicchio/litefy that referenced this issue Jul 13, 2023
francesco-buscicchio added a commit to francesco-buscicchio/litefy that referenced this issue Jul 13, 2023
@francesco-buscicchio
Copy link
Contributor

@mathkruger I just pushed a solution to the problem could you give me feedback? In case it is positive could you close the issue?

francesco-buscicchio added a commit to francesco-buscicchio/litefy that referenced this issue Jul 13, 2023
@Sourav-Kumar-Panda
Copy link

Can i work on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants