Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

something wrong at startAuction: msg.sender and Validator. signer maybe not the same #415

Open
VictorECDSA opened this issue Aug 1, 2022 · 0 comments

Comments

@VictorECDSA
Copy link

contracts\staking\stakeManager\StakeManagerExtension.sol

    function startAuction(
        uint256 validatorId,
        uint256 amount,
        bool _acceptDelegation,
        bytes calldata _signerPubkey
    ) external 
        .................................................................

        uint256 senderValidatorId = signerToValidator[msg.sender];

        require(
            NFTContract.balanceOf(msg.sender) == 0 && // existing validators can't bid
                senderValidatorId != INCORRECT_VALIDATOR_ID,
            "Already used address"
        );

        .................................................................

As msg.sender and Validator. signer maybe not the same, I think the variable 'senderValidatorId' should be:

        uint256 senderValidatorId = signerToValidator[_getAndAssertSigner(_signerPubkey)];
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant