[Bug] Segmenting for "Number of Visits" returns non-matching visits

[9joshua]

What happened?

Segmentation reports for Number of Visits = 1 include visitors with more than one visit. Here the number of Unique Visitors and Visits metrics should be equivalent...

Searching the Visits Log shows some visitors who had 2 visits...

This issue also appears to affect Custom Reports which would be expected as the RAW data (as shown in the Visits Log) does not properly apply the number of visits condition.

What should happen?

Segmenting reports where the number of visits =1 should omit all visitors with more than 1 visit.

How can this be reproduced?

1. Create a Segment where "Number of Visits = 1"
2. View the visit log to find visitors with more than one visit
3. Observe the discrepancy between Visits and Unique Visitors - these metrics should be identical

Matomo version

5.0.3

PHP version

8.1

Server operating system

Linux

What browsers are you seeing the problem on?

Chrome

Computer operating system

Ubuntu

Relevant log output

No response

Validations

• Read our Contributing Guidelines.
• Follow our Security Policy.
• Check that there isn't already an issue that reports the same bug to avoid creating duplicates.
• The provided steps to reproduce is a minimal reproducible of the Bug.

[sgiehl]

Looking at the code this can be easily explained. We storing a visit counter with the visits. So if a visitor has three visits, the first visit has stored a 1, the second a 2, ...
The segment currently directly selects by this column. So if you are looking for equals 1, it will select the first visit of all visitors.
So this segment is kind of broken by design. It might return correct data when looking for e.g. greater than, but everything else might always include other visitors.