ENH: add concat #20
Merged
ENH: add concat #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a top level function `concat` and a `Cycler` method `concat` which will concatenate two cyclers. The method can be chained. closes matplotlib#1
|
Bump on this so we can do a 1.0 release with mpl 1.5.0 final. |
|
I can look at this over the weekend if that works for you? On Fri, Oct 9, 2015 at 4:46 PM, Thomas A Caswell notifications@github.com
|
|
|
||
| def test_concat(): | ||
| a = cycler('a', range(3)) | ||
| for con, chn in zip(a.concat(a), chain(a, a)): |
There was a problem hiding this comment.
I'd be inclined to test this with two different cyclers, the way this is tested it would be possible to completely ignore the other input and concatenate self with self (which of course, is not the behaviour we want).
|
👍 from me once the two comments are addressed. |
|
I think I have addressed both of @pelson comments. |
|
Thanks @tacaswell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a top level function
concatand aCyclermethodconcatwhichwill concatenate two cyclers. The method can be chained.
closes #1
I am still partial to using
&or|as the concatenation operator, but I don't think there is enough consensus to implement it.@OceanWolf @efiring @WeatherGod @pelson