Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation #2358

Open
MomentQYC opened this issue Feb 15, 2024 · 5 comments
Open

Add translation #2358

MomentQYC opened this issue Feb 15, 2024 · 5 comments
Labels
A-I18n Area: Internationalization

Comments

@MomentQYC
Copy link

MomentQYC commented Feb 15, 2024

Chinese (China, Simplified) translation is now complete
There may be some errors, but the whole should be fine

@MomentQYC
Copy link
Author

It seems that "Simplified Chinese" and "Chinese (China, Simplified)" are duplicated and can be directly replaced.

@sandhose sandhose added the A-I18n Area: Internationalization label Feb 16, 2024
@sandhose
Copy link
Member

Many thanks for your contribution! I did quickly reviewed through reverse-translation and approved most of them. They will be included in the next translation sync in the next release

@MomentQYC
Copy link
Author

Many thanks for your contribution! I did quickly reviewed through reverse-translation and approved most of them. They will be included in the next translation sync in the next release

Note that there are some fields that I have improved to make them easier to understand in the Chinese context.
The reason I'm not sure is that I haven't deployed the current version of MAS to confirm which fields correspond to which functions.

@sandhose
Copy link
Member

So there were a bunch of issues with the language fallback logic. I did move the zh-CN#Hans to zh#Hans in Localazy as this is the one we use in other projects.
I then made sure that zh-CN falls back to zh#Hans, which hopefully makes sense.

It should be deployed in a few minutes to the OIDC playground at https://auth-oidc.lab.element.dev if you want to try out

@MomentQYC
Copy link
Author

It should be deployed in a few minutes to the OIDC playground at https://auth-oidc.lab.element.dev if you want to try out

I fixed three errors based on what I've seen so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-I18n Area: Internationalization
Projects
None yet
Development

No branches or pull requests

2 participants