New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't compile user agent regexes on every call #2504

Open

sandhose opened this issue Mar 18, 2024 · 0 comments

Labels

T-Task

Member

sandhose commented Mar 18, 2024

We have a few regexes that are compiled on each UA parsing. Those should be in static cells instead and compiled on startup instead

matrix-authentication-service/crates/data-model/src/user_agent.rs

Line 48 in 5b5346e

    
           let regex = regex::Regex::new(r"^(?P<name>[^/]+)/(?P<version>[^ ]+) \((?P<segments>.+)\)$")

sandhose added the T-Task label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment