Fix scrolling in Firefox #227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #226
By removing the
scrollTo(0,0)in Index.svelte forunsubscribeCurrentRouteit seems like scrolling in Firefox is fixed.My guess is that in Firefox this
scrollTo'wins', whereas in Chromium the hash wins.I'm not sure if this
scrollTowas doing any heavy lifting; a cursory glance showed that most things still seem to work, but as I'm not the original author I'm not sure why this was in there.As such it is highly possible that I just accidentally removed Chesterton's Fence, but I felt this was at least worth putting out there :)