Skip to content
This repository has been archived by the owner on Nov 30, 2020. It is now read-only.

adding component tests #14

Open
matsp opened this issue Nov 6, 2017 · 9 comments
Open

adding component tests #14

matsp opened this issue Nov 6, 2017 · 9 comments

Comments

@matsp
Copy link
Owner

matsp commented Nov 6, 2017

  • snapshot testing the components at a minimum
@matsp matsp self-assigned this Nov 6, 2017
@matsp
Copy link
Owner Author

matsp commented May 20, 2018

Create "usage" components for each material component and use it for snapshot tests and usage section in the docs.

@matsp
Copy link
Owner Author

matsp commented Jun 11, 2018

Project is now configured to test SFC components with Jest.

@matsp matsp added the tests label Jun 11, 2018
@kolharsam
Copy link

Hey, @matsp I'm new around here how can I contribute to building new components and this particular issue? Also, I was thinking of helping to build some accessibility components?

@matsp
Copy link
Owner Author

matsp commented Sep 5, 2018

@Kolhar730 Hi! I would really appreciate any help from you 👍 At this particular issue you can help by adding tests / snapshot tests for the missing components. I already added some e.g. for Button or IconButton.

Another big pain for me is to keep track with mdc-web versions because of my daily work. There are actual two versions I need to upgrade. For this you have to go through the changelog of mdc-web and synchronize the changes with this project. If you are interested in that, please let me know. There are also coming new components from upstream.

I think I also need to create a small hands-on guide with steps for developers to start quickly🙃

@kolharsam
Copy link

kolharsam commented Sep 5, 2018

@matsp sure I'd like to step in wherever I can. If we could break it all down based on priority I'll start working on the same. Also, I'd require an introduction of some sort to begin work, if you can make time for it or I'll just try it figure it out.

@matsp
Copy link
Owner Author

matsp commented Sep 6, 2018

@Kolhar730 Okay that sounds great 👍 I'am starting to write a quick developer guide and afterwards setting up the project with issues (with priorities). I really appreciate your help!

@kolharsam
Copy link

kolharsam commented Sep 6, 2018

@matsp Let me start off by adding tests to some more components. If you'd like to look into something else, let me know. 👍

Also, let me know if I can connect with you on Twitter or something? I'm a beginner and would love some more insight into contributing more to this project.

@matsp
Copy link
Owner Author

matsp commented Sep 6, 2018

@Kolhar730 My twitter account name is MatsPfeiffer, just hit me there.

@matsp
Copy link
Owner Author

matsp commented Sep 6, 2018

You can also join on discord, you will find the invitation link on the badge at the top of the README.

@tychenjiajun tychenjiajun pinned this issue May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants