Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-58025 Resolved automatic tz not reflecting without refresh by listening to app visibility event #26957

Merged
merged 6 commits into from May 23, 2024

Conversation

fasal26
Copy link
Contributor

@fasal26 fasal26 commented May 5, 2024

Summary

Resolved automatic tz not reflecting without refresh by listening to app visibility event

Ticket Link

Fixes #26911

Release Note

Added visibilitychange js browser event for updating user's current timeZone

@mm-cloud-bot
Copy link

@fasal26: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mattermost-build
Copy link
Contributor

Hello @fasal26,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@hanzei hanzei requested review from larkox and hmhealey May 6, 2024 07:26
@hanzei hanzei added the 2: Dev Review Requires review by a developer label May 6, 2024
@mm-cloud-bot mm-cloud-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed labels May 6, 2024
@hanzei hanzei added the 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review label May 6, 2024
@unified-ci-app
Copy link
Contributor

unified-ci-app bot commented May 6, 2024

Enterprise tests are not yet completed. You need to wait until Enterprise CI/docker-image status check is successful, before triggering E2E tests.

Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart of the linting issues, look good to me.

@fasal26
Copy link
Contributor Author

fasal26 commented May 11, 2024

Apart of the linting issues, look good to me.

@larkox
linting issues resolved

@hmhealey
Copy link
Member

hmhealey commented May 13, 2024

Some of the issues have been resolved, but the linter that you used reorganized the imports in a way that don't match our linting rules. Would you mind fixing those as well?

ESLint should be able to fix those automatically if you run npm run fix

@fasal26
Copy link
Contributor Author

fasal26 commented May 20, 2024

Some of the issues have been resolved, but the linter that you used reorganized the imports in a way that don't match our linting rules. Would you mind fixing those as well?

ESLint should be able to fix those automatically if you run npm run fix

Resolved

@hmhealey hmhealey changed the title [PR] Resolved automatic tz not reflecting without refresh by listening to app visibility event MM-58025 Resolved automatic tz not reflecting without refresh by listening to app visibility event May 21, 2024
Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that! This looks good to me now

@hmhealey hmhealey removed the 2: Dev Review Requires review by a developer label May 21, 2024
@yasserfaraazkhan
Copy link
Contributor

/e2e-tests

@unified-ci-app
Copy link
Contributor

E2E test triggered successfully for PR #26957. The corresponding commit's status check will be available shortly.

Copy link

E2E test run is starting for commit 1a32d3c41a5a6ffa884c542c4750b34c244e339d.
You can check its progress by either:

@yasserfaraazkhan yasserfaraazkhan added the Setup Cloud Test Server Setup an on-prem test server label May 23, 2024
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified changing timezone from MM setting and locally.
the posts timestamps show appropriate time.

@larkox larkox removed the 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review label May 23, 2024
@larkox larkox added the 4: Reviews Complete All reviewers have approved the pull request label May 23, 2024
@hmhealey hmhealey merged commit 24fbf2c into mattermost:master May 23, 2024
16 checks passed
@mattermost-build mattermost-build removed the Setup Cloud Test Server Setup an on-prem test server label May 23, 2024
@mm-cloud-bot
Copy link

Test server destroyed

1 similar comment
@mm-cloud-bot
Copy link

Test server destroyed

@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Contributor Docs/Not Needed Does not require documentation release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic time zone is not updated without refreshing page
8 participants