Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread move feature is incorrectly limited to system admins #26959

Open
mattermod opened this issue May 6, 2024 · 7 comments · May be fixed by #27061
Open

Thread move feature is incorrectly limited to system admins #26959

mattermod opened this issue May 6, 2024 · 7 comments · May be fixed by #27061
Assignees
Labels

Comments

@mattermod
Copy link
Contributor

Steps to reproduce:

  1. Enabled MoveThreadsEnabled feature flag
  2. Got Move Thread settings page in the System Console
  3. Add channel_admin to the Permitted Roles setting
  4. Create a post as a channel admin
  5. Open the post menu

Expected behaviour:

The Move thread option is present in the dropdown

Observed behaviour:

The Move thread option is not present in the dropdown


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-57988

@MattSilvaa
Copy link
Contributor

Hello! I'd be interested in working on this issue.

@marianunez
Copy link
Member

Thanks @MattSilvaa! All yours 🎉

@MattSilvaa
Copy link
Contributor

@marianunez I believe that this feature is actually behind the paid version of mattermost and thus, I won't be able to contribute. Could you please double check this? Thank you!

@marianunez
Copy link
Member

@marianunez I believe that this feature is actually behind the paid version of mattermost and thus, I won't be able to contribute. Could you please double check this? Thank you!

@MattSilvaa If you are still interested in contributing, I can provide a test license for local development. If not, feel free to pick any other help wanted ticket that is up for grabs. LMK

@MattSilvaa
Copy link
Contributor

That would be awesome! Im definitely still interested in helping out 😁

@marianunez
Copy link
Member

marianunez commented May 14, 2024

@MattSilvaa Apologies for the delayed response.

Here is a test license you can use locally in your dev environment to unlock enterprise features. Just rename the file to a .mattermost-license extension. Thanks!
DevCommunityLicense.txt

@MattSilvaa
Copy link
Contributor

MattSilvaa commented May 16, 2024

Thank you, @marianunez! I'll get a PR up soon for this

EDIT: License worked as expected. Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants