Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastwalk function is slow because of walking the excluded directories #40

Open
aminya opened this issue Jan 2, 2023 · 3 comments
Open

fastwalk function is slow because of walking the excluded directories #40

aminya opened this issue Jan 2, 2023 · 3 comments

Comments

@aminya
Copy link

aminya commented Jan 2, 2023

The library still tries to read the excluded directory using the fastwalk function.

    sources:
      ["node_modules/**/*", "**/*.js"]

I have done some profiling on my fork of go-task, and here is the result. As you see, it reads the whole node_modules directory, which takes 70 seconds.

image

image

Mirrored from go-task/task#225 (comment)
@aminya aminya changed the title The fastwalk function is slow because it still walks excluded directories fastwalk function is slow because of walking the excluded directories Jan 2, 2023
@aminya aminya mentioned this issue Jan 2, 2023
Closed
@aminya
Copy link
Author

aminya commented Jan 2, 2023

I verified that #41 fixes the issue.

There was an unnecessary check that prevented the skipping.

@krystian-panek-wttech
Copy link

finally... are exclusions implemented correctly? I mean - #41 (comment) - it is resolved or not...

@aminya
Copy link
Author

aminya commented Aug 1, 2023

finally... are exclusions implemented correctly? I mean - #41 (comment) - it is resolved or not...

This is not fixed yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix the directory skipping check aminya/go-zglob
2 participants
@aminya @krystian-panek-wttech