Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How big is the difference from 1.6.* to 2.* ? #64

Open
StoneCypher opened this issue Dec 24, 2019 · 3 comments
Open

How big is the difference from 1.6.* to 2.* ? #64

StoneCypher opened this issue Dec 24, 2019 · 3 comments

Comments

@StoneCypher
Copy link

One of the dependencies of 1.6.* has a security vulnerability that GitHub constantly warns about. It's not in 2.* - it's disparity.

Unfortunately, the fix to diff was incorrectly applied to disparity as a new major, instead of as a minor, meaning its downstreams aren't updating, so the "fix" isn't in place.

Can a user of 1.6.* use 2.*?

Could ... could I talk you into patching and publishing a new 1.6? It's just a version bump, and nyc / ava are throwing security faults on this.

@StoneCypher
Copy link
Author

Tree back is diff (patched) ← disparity (patched wrongly) ← concat-stream 1.6

Disparity 2 should have been patched as a 2.* but instead got patched as a 3.*, meaning your package, which should pick it up, doesn't

Screen Shot 2019-12-24 at 12 33 12 PM

Even though it's not your fault or problem, a new concat-stream 1.6 that bumped disparity to 3 could solve this immediately

@StoneCypher
Copy link
Author

This also throws for documentation.js

Relevant thread from disparity

@qm3ster
Copy link

qm3ster commented Sep 29, 2020

It seems that the only difference was a88de2c.
If I had to guess, the major version was bumped because it increased minimum nodejs version from 0.8 to 6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants