Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work correctly with FallbackGroupHandler #85

Open
2 tasks done
tahirm opened this issue Apr 3, 2020 · 1 comment
Open
2 tasks done

Does not work correctly with FallbackGroupHandler #85

tahirm opened this issue Apr 3, 2020 · 1 comment
Assignees
Labels

Comments

@tahirm
Copy link

tahirm commented Apr 3, 2020

Describe the bug
Monolog FallbackGroupHandler expects handlers to throw error while they are handling the records. CloudWatch handler does not throw cloudwatch connection related errors during call to handling process.
Only when everything is finished (in close()), CloudWatch handler realizes that its not able to connect etc. and then there is an exception, but it's already too late in case of FallbackGroupHandler.

Expected behavior
CloudWatch should check during the handling of the record, if it's able to connect to cloudwatch service or not. If it's not able to connect, it should through proper error.

Please provide the steps to reproduce and if possible a minimal demo of the problem

  • Define a FallbackGroupHandler with CloudWatch as first handler and file as second handler in the group.
  • Make cloudwatch service fail (wrong credentials etc.)
  • Expected: File handler is executed when CloudWatch handler fails.
  • Actual: File handler is not executed when CloudWatch handler fails, because CloudWatch handler does not throw exception during handle() call.

Please tell about your environment:

  • PHP Version: 7.3.12
  • Operating system (distro): Alpine Linux v3.10
  • Application mode:
    • Web app
    • CLI app
@lorenzowoodridge
Copy link

I'm having the same issue. Any updates or fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants