Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AWS Limits Race-Condition #113

Closed
wants to merge 1 commit into from
Closed

fix AWS Limits Race-Condition #113

wants to merge 1 commit into from

Conversation

digitalkaoz
Copy link

@digitalkaoz digitalkaoz commented Jan 11, 2023 •
edited

BugFix

fix initializing phase by sending logs to buffer during initialization by introducing a second variable initializing so subsequent log calls wont call the initialize phase again.

Update

  • removed deprecated sequenceToken
  • added proper typehints (might break php7, but its deprecated anyways)

fixes #111
fixes #86

its definitly a BC break, so a new major version would be needed

@digitalkaoz
fix AWS Limits Race-Condition
cc4a431 
remove deprecated SequenceToken, fix initializing by sending logs to buffer during initialization.
@digitalkaoz
Copy link
Author

well actually it doesnt solve the problem in reality. the solutions was to disable createGroup and create the group & stream proactivly.

Remember PHP is stateless, so every Requests kicks on the Describe Groups Stuff which raises the RateLimitException on heavy load

@a10waveracer a10waveracer mentioned this pull request Feb 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@digitalkaoz