Components are getting lost on combining

[mojoaxel]

In #35 a support for definitions has been added. These definitions are from the Swagger 2 version and have been replaced by components in OpenApi 3.

At the moment all these model definitions get removed.

This is part of the OpenApi v3 support (#4)

[shoaib-shah-iag]

@mojoaxel I think the resolution at #35 have missed few key things:

1. Only include the definitions/models for the endpoints that included (or not excluded). Current resolution includes all the definitions.
2. Remove definitions from inlines and rather have $ref to the definitions, when --includeDefinitions flag is passed in. Current implementation adds the definitions as well as have those inline as well.
3. Will be great if we can get ability to exclude or include a definition (if this can be done first then at least can be used as a workaround for point 1)

[plittlewood-rpt]

@mojoaxel did you ever find a workaround for this problem? I've just run into it :)

[mojoaxel]

This issue is quite old.
We use v1.4.0 and openapi: '3.0.0' and it seams to work.
Maybe we can close this issue!?

[plittlewood-rpt]

Hmm thanks - I'm using the same versions and no dice here, I don't get a components section at all. Will keep having a play around with it