Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Missin elevation 0 #9157

Closed
FernandoFranco opened this issue Sep 30, 2019 · 4 comments · May be fixed by maxiplux/full-stack-fastapi-couchbase#10, ajesse11x/ethereumbook#1 or ajesse11x/vuetify#2
Closed

[Bug Report] Missin elevation 0 #9157

FernandoFranco opened this issue Sep 30, 2019 · 4 comments · May be fixed by maxiplux/full-stack-fastapi-couchbase#10, ajesse11x/ethereumbook#1 or ajesse11x/vuetify#2
Assignees
@johnleider
Labels
T: bug Functionality that does not work as intended/expected
Milestone
v2.1.x

Comments

@FernandoFranco
Copy link
Contributor

Environment

Vuetify Version: 1.5.18
Vue Version: 2.6.10
Browsers: Google Chrome, Mozilla Firefox, Safari, Microsoft Edge, Internet Explorer, Opera
OS: Linux, Mac OSX, iOS, Android, Windows

Steps to reproduce

Create a card with elevation 0

Expected Behavior

Card with elevation 0 (flat)

Actual Behavior

Card with default elevation

Reproduction Link

https://codepen.io/fernando_franco/pen/RwbzZxP

Other comments

Change line 15 in https://github.com/vuetifyjs/vuetify/blob/v1.5.18/packages/vuetify/src/mixins/elevatable.ts to:

if (!this.computedElevation && this.computedElevation !== 0) return {}
@ghost ghost added the S: triage label Sep 30, 2019
@ant1m4tt3r ant1m4tt3r mentioned this issue Oct 2, 2019
Merged
9 tasks
@ant1m4tt3r
Copy link
Contributor

on it

@ant1m4tt3r
Copy link
Contributor

ps: this bug does not appear to happen on 2.x.x versions

@FernandoFranco FernandoFranco reopened this Oct 3, 2019
@FernandoFranco
Copy link
Contributor Author

ps: this bug does not appear to happen on 2.x.x versions

I didn't really check in versions 2.x.x

johnleider pushed a commit that referenced this issue Oct 11, 2019
@johnleider
fix(elevatable): fix elevation 0 not being accepted (#9173)
a7df4cc 
fixes #9157
@johnleider
Copy link
Member

fixed in a7df4cc

@johnleider johnleider added this to the v2.1.x milestone Oct 11, 2019
@johnleider johnleider self-assigned this Oct 11, 2019
@johnleider johnleider added T: bug Functionality that does not work as intended/expected and removed S: triage labels Oct 11, 2019
This was referenced Oct 23, 2019
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnleider johnleider

Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v2.1.x
3 participants
@FernandoFranco @johnleider @ant1m4tt3r