From 691574e17f61c4b88aeb62ec2e643ec2c8b7215d Mon Sep 17 00:00:00 2001 From: Keith Maxwell Date: Mon, 20 Jun 2022 11:33:35 +0100 Subject: [PATCH] Upgrade commander - In version 7 there was a breaking change https://github.com/tj/commander.js/blob/master/CHANGELOG.md#700-2021-01-15 - By default, options are no longer available on program https://github.com/tj/commander.js/pull/1409 - Updated code to follow the quick start example https://github.com/tj/commander.js#quick-start --- a4.js | 7 ++++--- package-lock.json | 16 ++++++++-------- package.json | 2 +- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/a4.js b/a4.js index 04e0655..2e89c94 100755 --- a/a4.js +++ b/a4.js @@ -65,6 +65,7 @@ if (flagged) { } (async () => { + const options = program.opts(); const browser = await puppeteer.launch({ executablePath: paths.filter(existsSync)[0], }); @@ -75,12 +76,12 @@ if (flagged) { await page.pdf({ ...{ path: pdf, - format: program.format, - landscape: program.landscape || false, + format: options.format, + landscape: options.landscape || false, /* margins set to 25mm to match Microsoft Word Online defaults */ margin: { top: "25mm", right: "25mm", bottom: "25mm", left: "25mm" }, }, - ...(program.number ? numbering : {}), + ...(options.number ? numbering : {}), }); await browser.close(); diff --git a/package-lock.json b/package-lock.json index 2a72206..3c51857 100644 --- a/package-lock.json +++ b/package-lock.json @@ -9,7 +9,7 @@ "version": "0.0.1", "license": "MPL-2.0", "dependencies": { - "commander": "^6.2.1", + "commander": "^9.3.0", "puppeteer-core": "^14.4.1" }, "bin": { @@ -122,11 +122,11 @@ "integrity": "sha512-jJ0bqzaylmJtVnNgzTeSOs8DPavpbYgEr/b0YL8/2GO3xJEhInFmhKMUnEJQjZumK7KXGFhUy89PrsJWlakBVg==" }, "node_modules/commander": { - "version": "6.2.1", - "resolved": "https://registry.npmjs.org/commander/-/commander-6.2.1.tgz", - "integrity": "sha512-U7VdrJFnJgo4xjrHpTzu0yrHPGImdsmD95ZlgYSEajAn2JKzDhDTPG9kBTefmObL2w/ngeZnilk+OV9CG3d7UA==", + "version": "9.3.0", + "resolved": "https://registry.npmjs.org/commander/-/commander-9.3.0.tgz", + "integrity": "sha512-hv95iU5uXPbK83mjrJKuZyFM/LBAoCV/XhVGkS5Je6tl7sxr6A0ITMw5WoRV46/UaJ46Nllm3Xt7IaJhXTIkzw==", "engines": { - "node": ">= 6" + "node": "^12.20.0 || >=14" } }, "node_modules/concat-map": { @@ -692,9 +692,9 @@ "integrity": "sha512-jJ0bqzaylmJtVnNgzTeSOs8DPavpbYgEr/b0YL8/2GO3xJEhInFmhKMUnEJQjZumK7KXGFhUy89PrsJWlakBVg==" }, "commander": { - "version": "6.2.1", - "resolved": "https://registry.npmjs.org/commander/-/commander-6.2.1.tgz", - "integrity": "sha512-U7VdrJFnJgo4xjrHpTzu0yrHPGImdsmD95ZlgYSEajAn2JKzDhDTPG9kBTefmObL2w/ngeZnilk+OV9CG3d7UA==" + "version": "9.3.0", + "resolved": "https://registry.npmjs.org/commander/-/commander-9.3.0.tgz", + "integrity": "sha512-hv95iU5uXPbK83mjrJKuZyFM/LBAoCV/XhVGkS5Je6tl7sxr6A0ITMw5WoRV46/UaJ46Nllm3Xt7IaJhXTIkzw==" }, "concat-map": { "version": "0.0.1", diff --git a/package.json b/package.json index dfe6de4..29e96a8 100644 --- a/package.json +++ b/package.json @@ -25,7 +25,7 @@ "homepage": "https://github.com/maxwell-k/a4#readme", "bin": "a4.js", "dependencies": { - "commander": "^6.2.1", + "commander": "^9.3.0", "puppeteer-core": "^14.4.1" }, "resolutions": {