-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When exchange rates are not available, foreign currency account rollups should show a warning UI + message #724
Comments
@jakubkottnauer since populating exchange rates requires a user to potentially spend money, the app needs to assume that rates cannot always be populated in full and have sensible ways of handling that. The behavior we're seeing here is the original intention, but may not be the best way to handle it. What do you think is the best way to display the data when a user has not synced exchange rates? |
Gotcha, yes, I think what you suggest would be fine. Maybe we could, in addition to the user action prompt, also show a little icon next to all the balances that are impacted by the missing exchange rate (as an example, in your screenshot the USD accounts in the sidebar would be shown normally, but foreign currency accounts would have the icon next to the balance) |
@jakubkottnauer I'd agree with that—having granular "hints" that lead the user to full explanations / troubleshooting guides would be ideal here. |
Somewhat related to this, but is there (or is there a plan for it) a way to set the "default" currency? The reason I think is related is: If I use this app only in BRL, I don't need an exchange rate in order to show the sum in the navbar. |
I don't know how the heck I missed that 🤦♂️ Thank you! |
Describe the bug
The balance sums shown next to the collapsible account groups in the sidebar don't include accounts in foreign currencies, if today's exchange rates for those currencies are missing in the database.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Account group balances in the sidebar should take foreign currencies into account. In the screenshot below, the number next to
Other Liability
should be roughly$1020.00
(200 SEK ~ 20 USD)Screenshots / Recordings
Additional context
The issue is caused by a missing exchange rate when this check is performed:
maybe/lib/money.rb
Line 31 in 79789bd
Perhaps we should sync the account right after it's created? Or at the very least call
account.sync_exchange_rates
. We'll also need to fetch exchange rates periodically or upon login, otherwise the bug reappears the next day.The text was updated successfully, but these errors were encountered: