Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation to Spanish #42

Open
giocodes opened this issue Sep 29, 2017 · 9 comments
Open

Translation to Spanish #42

giocodes opened this issue Sep 29, 2017 · 9 comments

Comments

@giocodes
Copy link

Hey Manuel, Great job here! I would like to help with the translation to Spanish. Is that something you would be interested?

@mbeaudru
Copy link
Owner

mbeaudru commented Oct 1, 2017

Hi @giocodes ! Thanks for the compliment 😅

I'm very interested in a spanish translation like in any language translation 👍 I answered this question in the chinese translation issue.

However, you might want to look at the forks if someone has already started to do one on his side to avoid doing the work twice.

@giocodes
Copy link
Author

giocodes commented Oct 1, 2017

Cool! I looked through the forks and didn´t find indications that a Spanish translation it´s in progress. I´ll start working on it a put a pull request soon.
Thanks @mbeaudru !

@giocodes
Copy link
Author

giocodes commented Oct 1, 2017

I´ve completed a fragment of the translation to Spanish over here.
https://github.com/giocodes/modern-js-cheatsheet/blob/master/translations/es-MX.md

I would like to see if someone else wants to provide feedback or help with parts of the translation. In any case, I´ll continue working on it in the next couple of days.

@camilogiraldo
Copy link

Hey @giocodes, I'm interested in help you providing some feedback and translating some parts of the documentation.

How can we proceed to make sure we don't do the work twice?

@jenni
Copy link

jenni commented Oct 12, 2017

Hi @giocodes I would be happy to take part of the Spanish translation too. Maybe we can align with @camilogiraldo and see how to do to avoid duplication? cheers.

@giocodes
Copy link
Author

Hey @camilogiraldo and @Jen-V I've created a fork to work on the translation over here:
https://github.com/giocodes/modern-js-cheatsheet/blob/master/translations/es-MX.md

  1. For suggestions and contributions I suggest we create an issue over the Spanish translation fork.
    1.1 For suggestions I'll can fix them directly.
    1.2 For new contributions, indicate the module you will be working on under the issue description, that way other contributors don't work on the same module.
  2. Create a pull request agains the Spanish translation fork
  3. Once the translation fork is completed or well advanced we can make a pull request against the main repository.

If you like this workflow start creating issues over there and let's get this done 😄

Gracias!!

@giocodes
Copy link
Author

@camilogiraldo and @Jen-V I've added some examples of issues that are completed and just need review.
https://github.com/giocodes/modern-js-cheatsheet/issues 😃

@GMaiolo
Copy link

GMaiolo commented Oct 30, 2017

@giocodes I commented a week ago on an issue and haven't got an answer, is that repo dead?
If it is I'd start another one right away.

@giocodes
Copy link
Author

@GMaiolo thanks for the review I'll apply those comments tonight. What would you like to work on next? Go ahead a create a new issue if you want to begin translating a module or there is another ticket pending review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants