Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@go.log_command should set _GO_LOG_FORMATTING #209

Open
mbland opened this issue Sep 5, 2017 · 0 comments
Open

@go.log_command should set _GO_LOG_FORMATTING #209

mbland opened this issue Sep 5, 2017 · 0 comments
Assignees
Labels
Projects
Milestone

Comments

@mbland
Copy link
Owner

mbland commented Sep 5, 2017

I noticed when running ./go install from mbland/dev-setup that the scripts that call @go.log inside a @go.log_command call weren't colorizing their output. Should be an easy fix for @go.log_command to set _GO_LOG_FORMATTING='true' when the output file descriptor is a terminal.

Now that I think about it, _GO_LOG_FORMATTING could be an array, so that it could be set for each file descriptor as appropriate...

@mbland mbland added the bug label Sep 5, 2017
@mbland mbland added this to the v1.7.0 milestone Sep 5, 2017
@mbland mbland self-assigned this Sep 5, 2017
@mbland mbland added this to Backlog in v1.7.0 Sep 5, 2017
@mbland mbland modified the milestones: v1.7.0, v1.8.0 Oct 8, 2017
@mbland mbland removed this from Backlog in v1.7.0 Oct 8, 2017
@mbland mbland added this to Backlog in v1.8.0 Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
v1.8.0
Backlog
Development

No branches or pull requests

1 participant