Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVG] SVG Favicon respects color-scheme of embedder #19450

Closed
5 of 7 tasks
hamishwillee opened this issue Aug 12, 2022 · 1 comment
Closed
5 of 7 tasks

[SVG] SVG Favicon respects color-scheme of embedder #19450

hamishwillee opened this issue Aug 12, 2022 · 1 comment
Assignees
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@hamishwillee
Copy link
Collaborator

hamishwillee commented Aug 12, 2022

Acceptance Criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
    or
  • Add entry to Firefox experimental features page if feature is not yet enabled in release

Features to document

Add a release note that SVG favicons with prefers-color-scheme will respect the color-scheme of the embedder.

Related Gecko bugs

https://bugzilla.mozilla.org/show_bug.cgi?id=1764354

Other

prefers-color-scheme media query is supposed to reflect the user preference for a dark/light theme set via the device or browser settings. This came up because there was a bug report where an SVG favicon was not visible on firefox because the prefers-color-scheme was triggering on the OS (light theme) while firefox was set to dark theme.

The solution was to clarify that the prefers-color-scheme must follow the color-scheme of the embedder - i.e. a clarification of the spec.

This seems to fix the favicon case, but is being generalized in #19449.

@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Aug 12, 2022
@hamishwillee hamishwillee changed the title [CSS] Needs investigation https://bugzilla.mozilla.org/show_bug.cgi?id=1779457 and https://bugzilla.mozilla.org/show_bug.cgi?id=1764354 [SVG] SVG Favicon respects color-scheme of embedder Aug 12, 2022
@hamishwillee hamishwillee self-assigned this Aug 15, 2022
@hamishwillee
Copy link
Collaborator Author

hamishwillee commented Aug 23, 2022

Status: Don

This is a very niche and focused change that will be generalized FF105: #19449. Agreed with developer worth just adding a release note for this particular part.

@Rumyra Rumyra closed this as completed Sep 5, 2022
@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 101 labels Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
Archived in project
Development

No branches or pull requests

3 participants