-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSS] Implement trigonometric functions and constants #19832
Comments
see Ramiy's comment below for the status of PRs |
Hi @Rumyra , Since Firefox 103, those functions are behind the We need to make sure they will ship in Firefox 105 (not Nightly). Please read the comments at mdn/browser-compat-data#17505 |
Hi @ramiy that's great, thanks a lot for your contribution. Do you already have a branch for the outstanding functions? I think we could probably get them all to land in a single PR, what do you think? |
No, they are not ready yet. |
OK, thanks. Would you like to collaborate on a fork? I can open a draft PR to compare changes if that's convenient. Let me know how you would like to proceed. |
Hi @ramiy - these are to be shipped in 105 - see the afore mentioned bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1774589 Hence why the issue is open, as the content team works on updates monthly. As these are for 105 we're looking to get them complete by the end of next week. If you need @bsmth support to do this please let us know - thanks! |
They are not enabled by default in 105, but behind a flag. https://searchfox.org/mozilla-beta/source/modules/libpref/init/StaticPrefList.yaml#7633-7638 https://bugzilla.mozilla.org/show_bug.cgi?id=1787070 will enable them. |
As I see it now, the only outstanding changes are BCD updates. I'm holding off from adding the I'm also skipping interactive examples for the moment because the mdn/content pages already have nice-looking examples. |
How should we document the trigonometric constants ( |
Shall we put them under numbers -> https://developer.mozilla.org/en-US/docs/Web/CSS/number
|
See the Calc Syntax section in the spec.
Should we create a new CSS data type ? Even is the answer is "no", eventually we will have to create this new type. |
I think we can skip that for now and add a "Numeric Constants" subsection to numbers for the moment, what do you think? We might indeed have to add a dedicated page in future. One thing to inform that decision: the spec lists these constants under math expressions not under numeric data types. |
Why am I hesitating? Because I prefer to create new data types for |
OK, I see your point. How about we mention I'm curious where |
@ramiy I think we should limit the scope of these changes for the moment. Let's just add some basic notes about the constants (one or two paras) as a sibling or child of numeric types either on the values or types page. We need to have a longer think about where it makes sense to have |
@ramiy -> If you would like to make bigger changes (i.e. adding pages), could you please fill out a content suggestion issue so we can plan for it? Thank you! :) |
See the calc syntax. The spec talks about calc-sum & friends too. I thin they should be documented in MDN. Some of the content currently documented in calc() will be moved to |
Yes, I think this makes sense. Could you please fill out a content suggestion issue so that we can track this? Thanks a lot |
@bsmth How is this one going? I was just doing a sweep of 105 items that still have dev-doc-needed and it includes these two:
Mostly just checking that 1682444 is part of this so we don't need another release issue to be created? |
Hi @hamishwillee thanks for checking. I think you're right in including this one into this ticket:
Although 1682444 looks unrelated, did you mean to link to this? |
Whoops. No. . Should we add a note to the calc one that it is addressed by this issue? |
Good idea, just added a comment to the bug 👍🏻 |
Thanks! I think its a generally good idea to cross link so that anyone in the team can tell that a bugzilla bug is already being addressed in some way. We're not so bad at that in more recent times. |
Acceptance Criteria
For folks helping with Firefox related documentation
dev-doc-complete
or
Features to document
Implement trigonometric functions and constants https://drafts.csswg.org/css-values-4/#trig-funcs
Related Gecko bugs
https://bugzilla.mozilla.org/show_bug.cgi?id=1774589
Issues and PRs
<calc-constant>
- New CSS data type #20856The text was updated successfully, but these errors were encountered: