Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples flash in Safari #10434

Closed
3 tasks done
romainmenke opened this issue Jan 31, 2024 · 4 comments
Closed
3 tasks done

Examples flash in Safari #10434

romainmenke opened this issue Jan 31, 2024 · 4 comments
Labels
3rd-party Issues related to third-parties, such as Pocket or Google Translate 🐛 bug Something isn't working, or isn't working as expected interactive-examples issues related to interactive examples (EmbedInteractiveExample macro)

Comments

@romainmenke
Copy link

romainmenke commented Jan 31, 2024

Summary

In Safari the examples embedded as iframes render over and over again leading to flashing content.

Warning the flashes are very intense

Screen.Recording.2024-01-31.at.14.54.21.mp4

In this screenshot I select the iframe in the debugger.
But it is unselected immediately because the element is deleted and recreated.

Screen.Recording.2024-01-31.at.14.55.01.mp4

URL

Any page with such examples.

Reproduction steps

  1. Use Safari
  2. Visit any MDN page with examples in iframes

Expected behavior

I didn't expect flashes

Actual behavior

A lot of flashes

Device

Desktop

Browser

Safari

Browser version

Stable

Operating system

Mac OS

Screenshot

No response

Anything else?

No response

Validations

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 31, 2024
@romainmenke romainmenke changed the title Examples flash in Safai Examples flash in Safari Jan 31, 2024
@argl argl added 🐛 bug Something isn't working, or isn't working as expected interactive-examples issues related to interactive examples (EmbedInteractiveExample macro) and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jan 31, 2024
@argl
Copy link
Contributor

argl commented Jan 31, 2024

@github-actions github-actions bot added the idle label Mar 2, 2024
@mirunacurtean
Copy link

Update
The examples have changed, but the flicker can still be reprroduced on more recent Safari versions (tested on 17.3 and 17.4)

Safari.17.3.mov
Screen.Recording.2024-05-17.at.13.21.00.mov

Note: Could not reproduce this on Safari 15.6 and 16.5, but that may be due to testing this on browserstack where the flicker rate seems reduced.

Safari.flickers.mov

@romainmenke
Copy link
Author

Can we give this a higher priority given that this is exactly the kind of strobing effect that is triggering for photosensitive epilepsy?

@github-actions github-actions bot removed the idle label May 17, 2024
@mirunacurtean mirunacurtean added the 3rd-party Issues related to third-parties, such as Pocket or Google Translate label May 20, 2024
@caugner
Copy link
Contributor

caugner commented May 20, 2024

Closing in favor of #10764.

@caugner caugner closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd-party Issues related to third-parties, such as Pocket or Google Translate 🐛 bug Something isn't working, or isn't working as expected interactive-examples issues related to interactive examples (EmbedInteractiveExample macro)
Projects
None yet
Development

No branches or pull requests

4 participants