Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDN intercepts Firefox's native / shortcut #10439

Open
eevee opened this issue Feb 1, 2024 · 6 comments
Open

MDN intercepts Firefox's native / shortcut #10439

eevee opened this issue Feb 1, 2024 · 6 comments
Labels
idle involves: Product Requires the attention of the Product team. involves: UX Requires the attention of the UX team. needs discussion ux make the user experience awesome

Comments

@eevee
Copy link

eevee commented Feb 1, 2024

Firefox uses / to mean "quick find in page". MDN intercepts that to mean the completely different "search the whole website". This is a very weird thing to do and sets a somewhat unpleasant precedent for the rest of the web, given that Mozilla's name is on both products.

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Feb 1, 2024
@caugner caugner added involves: Product Requires the attention of the Product team. involves: UX Requires the attention of the UX team. labels Feb 6, 2024
@argl argl added ux make the user experience awesome and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Feb 13, 2024
@argl argl changed the title MDN intercepts Firefox's native / shortcut MDN intercepts Firefox's native / shortcut Feb 13, 2024
@danielhjacobs
Copy link
Contributor

This was the original search shortcut. Ctrl-K was added as a secondary shortcut in #5962, and it was made not to trigger on Ctrl-Shift-K in #7067.

Note, the same shortcuts apply on GitHub (with two different purposes - Ctrl-K opens a "command-palette" inside a details-dialog element, while s or / focuses the typical search bar)

I assume this needs to be discussed. Slash, as a keyboard shortcut for search was added to yari in #93 by former MDN employee peterbe. It may have been copied from the pre-yari days.

@danielhjacobs
Copy link
Contributor

Also note, on any Google search page (e.g. https://www.google.com/search?q=test), slash focuses the search field, so this isn't entirely uncommon.

@eevee
Copy link
Author

eevee commented Mar 12, 2024

I did once manage to get GitHub to remove its / shortcut, but it snuck back in later. I suppose I'm not surprised that Google and Microsoft engineers don't bother checking if they're overriding Firefox shortcuts. :)

@danielhjacobs
Copy link
Contributor

danielhjacobs commented Mar 12, 2024

It's also worth noting, Ctrl-K itself is overriding a Firefox shortcut too. On websites where Ctrl-K does not have any other function, it searches your default search engine via the address bar.

It's a question of what the best keyboard shortcut for search might be and whether avoiding overriding shortcuts is so paramount that conventions followed by other websites should be ignored by MDN. I suppose the difference is Ctrl-K is pretty unpopular as a browser shortcut.

@danielhjacobs
Copy link
Contributor

On websites that override Ctrl-K, you can accomplish the same thing with Ctrl-L followed by Ctrl-K, but that's increasing the number of shortcuts to two instead of one.

@eevee
Copy link
Author

eevee commented Mar 12, 2024

I use Ctrl-K all the time and I've run afoul of that on MDN too, but at least I can press it a second time to get where I actually wanted to go.

Honestly, I don't understand the need to override useful native browser shortcuts for a single website at all. I, necessarily, use Firefox itself far more often than I use MDN (or any other singular site), so I'm much more invested in Firefox shortcuts than MDN shortcuts, and having / and Ctrl-K sometimes stop working is incredibly irritating. It's arguably worse with Ctrl-K, since that has nothing to do with the site that's open, so I don't develop very strong associations for when it will break. It just becomes a fun surprise.

GitHub's s seems fine. Or even the native accesskey, but I guess that's passé.

@github-actions github-actions bot added the idle label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle involves: Product Requires the attention of the Product team. involves: UX Requires the attention of the UX team. needs discussion ux make the user experience awesome
Projects
None yet
Development

No branches or pull requests

4 participants