fix(live-sample): fix live samples for safari #10775
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazy loading is tricky. Let's be more defensive. This hopefully resolves #10764 It looked like we were hitting a weird race condition in Safari. So checking for the source and removing the eventListener should only improve things. This also sets the initialized flag in the runner earlier to avoid races.
bsmth
reviewed
Mar 25, 2024
| @@ -56,16 +56,21 @@ export function initPlayIframe( | |||
| typ: "init", | |||
| state: editorContent, | |||
| }; | |||
| // Lazy loading is trick cross platform. | |||
There was a problem hiding this comment.
Suggested change
| // Lazy loading is trick cross platform. | |
| // Lazy loading is tricky cross platform. |
|
Converted to draft, as it doesn't resolve the issue (verified by deploying to stage). |
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lazy loading is tricky. Let's be more defensive.
This hopefully resolves #10764
Problem
It looked like we were hitting a weird race condition in Safari.
Checking for the source and removing the eventListener should only improve things. This also sets the initialized flag in the runner earlier to avoid races.
How did you test this change?
Locally but it's hard to reproduce.
Setting:
and disabling caching helps.