Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: remove the title parameter from smartLink() #10804

Open
yin1999 opened this issue Mar 27, 2024 · 1 comment
Open

proposal: remove the title parameter from smartLink() #10804

yin1999 opened this issue Mar 27, 2024 · 1 comment
Labels
engineering-request enahncement requests from community, writers and partners idle macros tracking issues related to kumascript macros on hold Waiting on something else before this can be moved forward. p4 Not urgent, only if time allows

Comments

@yin1999
Copy link
Member

yin1999 commented Mar 27, 2024

Context:

I'm trying to remove broken-link-flaw reports to missing translation as broken if en-US fallback exists from smartLink(). I found that the smartLink() method lacks documentation for its parameters and contains too many parameters, which makes it difficult to be used in macros.

As I dug deeper, I found that it will add a title attribute to the generated <a> tags when this arg is provided. Then I investigated the usage of smartLink() and found that only one macro passed the title parameter, and the set title overlapped with the link text:

I think we can safely remove this parameter and clean up the function calls.

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Mar 27, 2024
@argl argl added p4 Not urgent, only if time allows engineering-request enahncement requests from community, writers and partners macros tracking issues related to kumascript macros and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Apr 5, 2024
@caugner
Copy link
Contributor

caugner commented Apr 15, 2024

I think your suggestion makes sense, but we're currently working on a rewrite of the build system including macros, so we're refraining from making changes this like this at this point. I'll add the "on hold" label and we can get back to this later.

@caugner caugner added the on hold Waiting on something else before this can be moved forward. label Apr 15, 2024
@github-actions github-actions bot added the idle label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering-request enahncement requests from community, writers and partners idle macros tracking issues related to kumascript macros on hold Waiting on something else before this can be moved forward. p4 Not urgent, only if time allows
Projects
None yet
Development

No branches or pull requests

3 participants