Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking a link created using an @link JSDoc tag, opens the same file again in a weird state #394

Closed
4 tasks done
remcohaszing opened this issue Feb 9, 2024 · 4 comments
Closed
4 tasks done

Clicking a link created using an @link JSDoc tag, opens the same file again in a weird state #394

remcohaszing opened this issue Feb 9, 2024 · 4 comments
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🐛 type/bug This is a problem

Comments

@remcohaszing
Copy link
Member

Initial checklist

Affected packages and versions

unifiedjs.vscode-mdx

Link to runnable example

No response

Steps to reproduce

  1. Create an MDX file with the following content: 
    {/** {@link Component} */}
export function Component() {}
  2. Hover the Component function identifier.
  3. Click the Component link.
    Hover information the link mentioned

Expected behavior

The user is taken to the Component, which happens to be in the same place in this example. Within JavaScript files, this works as expected.

Actual behavior

The same file is opened in a new tab a weird state. The breadcrumbs show the full file path instead of a relative one.

The same file as above, but the breadcrumbs show the full file path.

Runtime

No response

Package manager

No response

OS

No response

Build and bundle tools

No response
@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Feb 9, 2024
@remcohaszing remcohaszing added 🐛 type/bug This is a problem 🗄 area/interface This affects the public interface 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Feb 9, 2024
@remcohaszing
Copy link
Member Author

remcohaszing commented Feb 9, 2024 •
edited

This was solved upstream in Volar 2.0.3.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@remcohaszing remcohaszing added the 💪 phase/solved Post is done label Feb 9, 2024
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Feb 9, 2024
@remcohaszing remcohaszing added the 🤞 phase/open Post is being triaged manually label Feb 10, 2024
@github-actions github-actions bot removed the 💪 phase/solved Post is done label Feb 10, 2024
@remcohaszing
Copy link
Member Author

This was solved for hover info, but not completion items.

@remcohaszing remcohaszing reopened this Feb 10, 2024
remcohaszing added a commit to volarjs/volar.js that referenced this issue Feb 10, 2024
@remcohaszing
fix(language-service): transform markdown links in completion items
7537aab 
This resolves completion item descriptions the same way as hover
descriptions are resolved.

The `transformDocumentLinkTarget` and `transformMarkdown` functions were
both moved into `utils/transform`, but their implementation remains the
same.

The fix was verified to work in MDX analyzer.

Refs mdx-js/mdx-analyzer#394
@remcohaszing remcohaszing mentioned this issue Feb 10, 2024
Merged
johnsoncodehk pushed a commit to volarjs/volar.js that referenced this issue Feb 10, 2024
@remcohaszing
fix(language-service): transform markdown links in completion items (#…
e1246a5 
…133)

This resolves completion item descriptions the same way as hover
descriptions are resolved.

The `transformDocumentLinkTarget` and `transformMarkdown` functions were
both moved into `utils/transform`, but their implementation remains the
same.

The fix was verified to work in MDX analyzer.

Refs mdx-js/mdx-analyzer#394
@remcohaszing remcohaszing added the 💪 phase/solved Post is done label Feb 26, 2024
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Feb 26, 2024
@remcohaszing
Copy link
Member Author

This bug was solved upstream in Volar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🐛 type/bug This is a problem
Milestone
No milestone
Development

No branches or pull requests
1 participant
@remcohaszing