Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mdx-js/mdx
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.17.3
Choose a base ref
...
head repository: mdx-js/mdx
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.17.4
Choose a head ref
  • 3 commits
  • 9 files changed
  • 2 contributors

Commits on Feb 15, 2019

  1. Add isMDXComponent static class prop to generated classes (#369) 

    * Add `isMDXElement` static class prop to generated classes

Adds the behavior discussed in #368

* s/element/component

* Add isMDXComponent test

* Define static class prop the old way

* Fix prettier error

* Revert new line removal

* Fix prettier error

* Add function to snapshot test

* Missed a ;

* Change isMDXComponent type to bool

Co-Authored-By: hugmanrique <hugmanrique@users.noreply.github.com>

* Apply suggestions from code review

Co-Authored-By: hugmanrique <hugmanrique@users.noreply.github.com>
    @hugmanrique @johno
    hugmanrique authored and johno committed Feb 15, 2019
    Copy the full SHA
    589f293 View commit details

  2. Fix test from isMDXComponent change (#402)

    @johno
    johno authored Feb 15, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    8bcd6ef View commit details

  3. v0.17.4

    @johno
    johno committed Feb 15, 2019
    Copy the full SHA
    f4ffb82 View commit details
2 changes: 1 addition & 1 deletion lerna.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"lerna": "3.4.0",
"version": "0.17.3",
"version": "0.17.4",
"packages": [
"packages/*"
],
4 changes: 2 additions & 2 deletions packages/loader/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mdx-js/loader",
"version": "0.17.3",
"version": "0.17.4",
"description": "Loader for MDX",
"license": "MIT",
"keywords": [
@@ -27,7 +27,7 @@
"index.js"
],
"dependencies": {
"@mdx-js/mdx": "^0.17.3",
"@mdx-js/mdx": "^0.17.4",
"@mdx-js/tag": "^0.17.0",
"loader-utils": "^1.1.0"
},
3 changes: 2 additions & 1 deletion packages/mdx/mdx-hast-to-jsx.js
View file
Original file line number Diff line number Diff line change
@@ -131,7 +131,8 @@ ${skipExport ? '' : 'export default'} class MDXContent extends React.Component {
.join('')}
</MDXTag>
}
}`
}
MDXContent.isMDXComponent = true`
)
}
// Recursively walk through children
2 changes: 1 addition & 1 deletion packages/mdx/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mdx-js/mdx",
"version": "0.17.3",
"version": "0.17.4",
"description": "Parse MDX and transpile to JSX",
"license": "MIT",
"keywords": [
9 changes: 8 additions & 1 deletion packages/mdx/test/index.test.js
View file
Original file line number Diff line number Diff line change
@@ -107,6 +107,7 @@ export default class MDXContent extends React.Component {
);
}
}
MDXContent.isMDXComponent = true;
"
`)
})
@@ -290,6 +291,11 @@ it('Should recognize components as properties', async () => {
)
})

it('Should contain static isMDXComponent() function', async () => {
const result = await mdx('# Hello World')
expect(result).toContain('MDXContent.isMDXComponent = true')
})

it('Should render elements without wrapping blank new lines', async () => {
const result = await mdx(`
| Test | Table |
@@ -413,6 +419,7 @@ export default class MDXContent extends React.Component {
</MDXTag>
}
}"
}
MDXContent.isMDXComponent = true"
`)
})
4 changes: 2 additions & 2 deletions packages/parcel-plugin-mdx/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mdx-js/parcel-plugin-mdx",
"version": "0.17.3",
"version": "0.17.4",
"description": "Parcel plugin for MDX",
"license": "MIT",
"keywords": [
@@ -27,7 +27,7 @@
"src"
],
"dependencies": {
"@mdx-js/mdx": "^0.17.3",
"@mdx-js/mdx": "^0.17.4",
"parcel-bundler": "^1.4.1"
},
"peerDependencies": {
2 changes: 1 addition & 1 deletion packages/remark-mdx/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "remark-mdx",
"version": "0.17.3",
"version": "0.17.4",
"description": "Support import, export, and JSX in markdown",
"license": "MIT",
"keywords": [
3 changes: 2 additions & 1 deletion packages/remark-mdx/test/__snapshots__/test.js.snap
View file
Original file line number Diff line number Diff line change
@@ -28,7 +28,8 @@ export default class MDXContent extends React.Component {
</Baz>
</MDXTag>
}
}"
}
MDXContent.isMDXComponent = true"
`;
exports[`maintains the proper positional info 1`] = `
4 changes: 2 additions & 2 deletions packages/runtime/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mdx-js/runtime",
"version": "0.17.3",
"version": "0.17.4",
"description": "Parse and render MDX in a runtime environment",
"license": "MIT",
"keywords": [
@@ -33,7 +33,7 @@
"src/"
],
"dependencies": {
"@mdx-js/mdx": "^0.17.3",
"@mdx-js/mdx": "^0.17.4",
"@mdx-js/tag": "^0.17.0",
"buble": "^0.19.6"
},