Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing space-separated properties #1048

Merged
merged 3 commits into from
May 1, 2020
Merged

Add missing space-separated properties #1048

merged 3 commits into from
May 1, 2020

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky commented May 1, 2020

rel arrays are being separated by commas in MDX, causing issues such as gatsbyjs/gatsby#22719

This PR (a followup to #715 and #158) hard-codes the current full list of space-separated properties from property-information. This is hard-coded because soon #1039 will land, which fixes the issue more correctly.

Ref: gatsbyjs/gatsby#22719 (comment)

cc @johno @wooorm

@vercel
Copy link

vercel bot commented May 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/50425m5gb
✅ Preview: https://mdx-git-fork-karlhorky-patch-1.mdx.now.sh

@vercel vercel bot temporarily deployed to Preview May 1, 2020 10:49 Inactive
@vercel vercel bot temporarily deployed to Preview May 1, 2020 10:50 Inactive
@johno
Copy link
Member

johno commented May 1, 2020

Thanks!

@johno johno merged commit 9b67788 into mdx-js:master May 1, 2020
@karlhorky karlhorky deleted the patch-1 branch May 1, 2020 16:34
@karlhorky
Copy link
Contributor Author

No worries, thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants