Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: options.file could be undefined error in toJSX #1156

Merged
merged 4 commits into from Jul 17, 2020

Conversation

dusave
Copy link

@dusave dusave commented Jul 17, 2020

toJSX could be called outside, see storybook, where options.file could be unavailable.

@vercel
Copy link

vercel bot commented Jul 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/c9p9ulate
✅ Preview: https://mdx-git-fork-dustinsavery-patch-1.mdx.vercel.app

@vercel vercel bot temporarily deployed to Preview July 17, 2020 03:51 Inactive
@vercel vercel bot temporarily deployed to Preview July 17, 2020 03:56 Inactive
@vercel vercel bot temporarily deployed to Preview July 17, 2020 04:03 Inactive
@vercel vercel bot temporarily deployed to Preview July 17, 2020 04:05 Inactive
@JounQin JounQin changed the title Fixing 'path' of undefined error fix: options.file could be undefined error in toJSX Jul 17, 2020
@JounQin JounQin merged commit 5a72524 into mdx-js:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants