Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add babel-plugin-remove-export-keywords #699

Merged
merged 3 commits into from
Jul 31, 2019
Merged

feat: Add babel-plugin-remove-export-keywords #699

merged 3 commits into from
Jul 31, 2019

Conversation

jletey
Copy link
Contributor

@jletey jletey commented Jul 31, 2019

@johno Here you go!

Closes GH-698

@vercel
Copy link

vercel bot commented Jul 31, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://mdx-git-fork-johnletey-feat-babel-keywords-package.mdx.now.sh

@vercel vercel bot temporarily deployed to staging July 31, 2019 17:53 Inactive
@johno
Copy link
Member

johno commented Jul 31, 2019

Thanks a ton! 😻 😻😻

Do you mind maybe bringing over the test and setting up the package.json to mirror the others in this project? 🙏

@vercel vercel bot temporarily deployed to staging July 31, 2019 18:24 Inactive
@jletey
Copy link
Contributor Author

jletey commented Jul 31, 2019

Sorry that took so long @johno ... but I have added the test (which doesn't pass because new-lines are added when it formats, but I didn't want to change anything before running it by you) and also have formatted the package.json like the rest of the packages

@johno
Copy link
Member

johno commented Jul 31, 2019

Amazing! Feel free to change the fixture so that it passes 👍

@jletey
Copy link
Contributor Author

jletey commented Jul 31, 2019

Will do!

@vercel vercel bot temporarily deployed to staging July 31, 2019 18:29 Inactive
@johno johno merged commit 238c497 into mdx-js:master Jul 31, 2019
@jletey jletey deleted the feat/babel-keywords-package branch July 31, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Exports should be transformed to variables in the playground/runtime
2 participants