Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force more engaging test on data clean #404

Open
chrisdanek opened this issue May 8, 2020 · 2 comments
Open

Force more engaging test on data clean #404

chrisdanek opened this issue May 8, 2020 · 2 comments
Assignees

Comments

@chrisdanek
Copy link
Contributor

Right now when running data clean I am asked to type in CLEAN DATA regardless of which environment I am targeting. My particular workflow is just typing a few letters in the console like pos-cli data and then browsing the history of previous commands. It may result in picking an invalid environment due to oversight. I try to double-check that each time, but sooner or later I’ll mess up and erase production :(

Actual behavior

[16:05:36]
[16:05:36] WARNING!!! You are going to REMOVE your data from instance: https://qa-golfstix.staging.oregon.platform-os.com/
[16:05:36] There is no coming back.
[16:05:36]
✔ If you still want to continue please type: 'CLEAN DATA'  … CLEAN DATA

Expected behavior

A more meaningful test would ask you to enter the name of the environment you want to clean so

[16:05:36]
[16:05:36] WARNING!!! You are going to REMOVE your data from instance: https://qa-golfstix.staging.oregon.platform-os.com/
[16:05:36] There is no coming back.
[16:05:36]
✔ If you still want to continue please type name of the environment: 'qa'  … qa

This way you make running data clean on the wrong instance harder.

Version

  • pos-cli: 4.4.11
  • node: v13.6.0
  • os: osx
@Slashek
Copy link
Contributor

Slashek commented May 8, 2020

data clean does not work on production, just saying :)

@chrisdanek
Copy link
Contributor Author

oh, good to know. Regardless, the more engaging test might be useful

@z-x z-x removed the enhancement label Jul 17, 2023
@z-x z-x assigned z-x and unassigned Slashek Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants