Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency on yanked ahash@0.7.6 #491

Open
dignifiedquire opened this issue Oct 23, 2023 · 5 comments
Open

dependency on yanked ahash@0.7.6 #491

dignifiedquire opened this issue Oct 23, 2023 · 5 comments
Milestone

Comments

@dignifiedquire
Copy link

This is through the outdated indexmap@1.9.3 -> hashbrown@0.12 -> ahash@0.7

@Dispersia
Copy link

Dispersia commented Oct 23, 2023

also just got hit with this, it already works in master, just needs a release cut as the dependency has already been updated. just temporarily pointing using git instead of version to fix it (unfortunately seems to have hit a lot of crates, including sqlx 0.6 thought 0.7 works)

@matthiasbeyer
Copy link
Collaborator

If you want, you can file a update PR targeting the release-0.13.x branch for updating indexmap and we'll see whether this runs through CI smoothly, so I can have that fixed in a 0.13.4 release...
Because 0.13.4 might be there sooner than 0.14.0... 🤔

@dignifiedquire
Copy link
Author

ahash@0.7.7 was released, making backports much less urgent luckily

@matthiasbeyer matthiasbeyer added this to the 0.14.0 milestone Oct 27, 2023
@matthiasbeyer
Copy link
Collaborator

So we can wait until dependabot comes around, can't we?

@polarathene
Copy link
Collaborator

polarathene commented Oct 31, 2023

Dependency resolved depends on rust toolchain used.

  • < 1.60.0 will resolve ordered-multimap 0.4.0 as newer releases bump hashbrown which uses newer ahash releases (that got yanked) and their recent releases that implicitly raise (since 0.7.6) the MSRV to Rust 1.60.0 due to new weak dependencies syntax usage in Cargo.toml. That syntax is considered invalid to older rust releases and so the crates don't appear to exist, rolling back until a valid dependency chain can be resolved.
  • >= 1.60.0 can resolve a newer ordered-multimap 0.4.3 (due to 0.4 semver).
  • Meanwhile, if rust-ini were to update (dependabot), that'll raise ordered-multimap to the newer 0.7 release which bumps MSRV to 1.71.1, unrelated to the hashbrown / ahash dependencies.

So we can wait until dependabot comes around, can't we?

No action required AFAIK?

@matthiasbeyer matthiasbeyer modified the milestones: 0.14.0, 0.15.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants