Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenization of japan text with disabled default features #229

Open
generall opened this issue Jul 17, 2023 · 3 comments
Open

Tokenization of japan text with disabled default features #229

generall opened this issue Jul 17, 2023 · 3 comments

Comments

@generall
Copy link

Hi!

We are trying to integrate Charabia in here: qdrant/qdrant#2260
Our big concern is binary size, that's why we are trying to use it with disabled dictionaries for Japanese, Korean and Chinese.

Version 7.2 seemed to have a default behavior of splitting text per-character in this case:

本日の日付は -> ["本", "日", "の", "日", "付", "は"]

which was fine for our purposes. New version, however, doesn't do that anymore:

本日の日付は -> ["本日の日付は"]

I wonder if it is an intended behavior change and is it possible to configure segmenter to behave in a way it worked before?

@ManyTheFish
Copy link
Member

So far it's not possible to split CJK characters like you want,
however, a new segmenter could be implemented to do the job and would be activated with a feature flag.
If you want to do a PR, I would agree to merge it. 😃

@XshubhamX
Copy link

Can I work on this @ManyTheFish

@curquiza
Copy link
Member

Hello @XshubhamX

Thanks for your interest in this project 🔥 You are definitely more than welcome to open a PR for this!

For your information, we prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages the volunteer contributors from opening a PR to fix this issue.
We will accept and merge the first PR that fixes correctly and well implements the issue following our contributing guidelines.

We are looking forward to reviewing your PR 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants