Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize "œ" / "æ" into "oe" / "ae" #268

Closed
ManyTheFish opened this issue Feb 13, 2024 · 0 comments · Fixed by #278
Closed

Normalize "œ" / "æ" into "oe" / "ae" #268

ManyTheFish opened this issue Feb 13, 2024 · 0 comments · Fixed by #278
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ManyTheFish
Copy link
Member

ManyTheFish commented Feb 13, 2024 •
edited

Implement a normalizer normalizing "œ" / "æ" into "oe" / "ae".

See the Normalizer template to fix this issue.

Related

Hey! 👋
Before starting any implementation, make sure that you read the CONTRIBUTING.md file.
In addition to the recurrent rules, you can find some guides to easily implement a Segmenter or a Normalizer.
Thanks a lot for your Contribution! 🤝
@ManyTheFish ManyTheFish mentioned this issue Feb 13, 2024
Open
@ManyTheFish ManyTheFish added enhancement New feature or request good first issue Good for newcomers labels Feb 13, 2024
@Soham1803 Soham1803 mentioned this issue Apr 6, 2024
Merged
3 tasks
meili-bors bot added a commit that referenced this issue Apr 29, 2024
@meili-bors @Soham1803
Merge #278
693c687 
278: Adds a new normalizer to normalize œ to oe and æ to ae r=ManyTheFish a=Soham1803

# Pull Request

## Related issue
Fixes #268

## What does this PR do?
- Creates a new normalizer *ae_oe_normalizer*
- normalizes `œ` and `Œ`  to `oe`,  `æ` and `Æ` to `ae`. 

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Soham <mastpanchalsoham@gmail.com>
@meili-bors meili-bors bot closed this as completed in 6b270fc May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds a new normalizer to normalize œ to oe and æ to ae Soham1803/charabia
1 participant
@ManyTheFish