New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
investigate graphql-jit fork of hoangvvo #315
Comments
Is development of graphql-jit stopped? Why was it forked? |
I believe he forked it for his own minimal graphql server implementation Benzene, but this is purely a deduction on my part. He did open up several PRs ([For discussion, do not merge] Remove fast-json-stringify and allows customJSONSerializer to be a function, Add Subscription support, Make fast-json-stringify optional). Which were not merged due to various reasons. (not complete, discussion pending or requires major other rework). Looks like he just went with a personal fork for his own project to circumvent aforementioned challenges. On another note, I do see that graphql-jit is not that actively developed. That was mainly the reason I opened up this issue. |
I would not switch to a fork at this point. If we have to, we'll do ours. I don't think there is any blockers right now on our end for which we'll need a fork. |
Please don't switch to my fork - it is for experimentation only. I just made a PR to add subscription here: zalando-incubator/graphql-jit#94 There is only one failing test that needs to be fixed |
I just stumbled upon a what I think is an interesting fork of graphql-jit by hoangvvo.
What mainly triggered my interest is the addition of supporting jit subscriptions. Might it be interesting to see how mercurius could benefit from this? If so, in what form?
The text was updated successfully, but these errors were encountered: